Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewportjob minor cleanup #3041

Merged
merged 4 commits into from
Dec 9, 2017
Merged

Viewportjob minor cleanup #3041

merged 4 commits into from
Dec 9, 2017

Conversation

jjatie
Copy link
Collaborator

@jjatie jjatie commented Nov 23, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Nov 23, 2017

Codecov Report

Merging #3041 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3041      +/-   ##
==========================================
+ Coverage   19.77%   19.79%   +0.02%     
==========================================
  Files         113      113              
  Lines       13663    13647      -16     
==========================================
  Hits         2702     2702              
+ Misses      10961    10945      -16
Impacted Files Coverage Δ
Source/Charts/Jobs/AnimatedMoveViewJob.swift 0% <ø> (ø) ⬆️
Source/Charts/Jobs/ZoomViewJob.swift 0% <0%> (ø) ⬆️
Source/Charts/Jobs/MoveViewJob.swift 0% <0%> (ø) ⬆️
Source/Charts/Jobs/AnimatedViewPortJob.swift 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc40b16...416b636. Read the comment docs.

@liuxuan30 liuxuan30 merged commit d321093 into ChartsOrg:master Dec 9, 2017
@jjatie jjatie deleted the viewportjob-minor-cleanup branch December 9, 2017 18:58
FreddyZeng added a commit to FreddyZeng/Charts that referenced this pull request Jan 2, 2018
* 'master' of https://github.com/danielgindi/Charts: (23 commits)
  Update ViewPortHandler.swift (ChartsOrg#3143)
  add option to build demo projects unit tests on iOS (ChartsOrg#3121)
  Replaced relevant `ChartUtils` methods with `Double` extensions (ChartsOrg#2994)
  Update 4.0.0 with master (ChartsOrg#3135)
  Removed redundant ivars in BarLineChartViewBase (ChartsOrg#3043)
  fix ChartsOrg#1830. credit from ChartsOrg#2049 (ChartsOrg#2874)
  Makes ChartsDemo compiling again (ChartsOrg#3117)
  Fixed using wrong axis (Issue ChartsOrg#2257)
  Removed methods and properties deprecated in 1.0 (ChartsOrg#2996)
  for ChartsOrg#3061 revert animationUpdate() and animationEnd() not trigger crash if subclass does nothing
  The backing var is not necessary. (ChartsOrg#3000)
  Replaced `ChartUtils.Math` in favour of an extension on `FloatingPoint` (ChartsOrg#2993)
  Minor logic cleanup (ChartsOrg#3041)
  Fix a bug may cause infinite loop. (ChartsOrg#3073)
  for ChartsOrg#2745. chart should be weak.
  fileprivate -> private (ChartsOrg#3042)
  Removed `isKind(of:)`
  Removed @objc from internal properties
  Fixes for PR
  Made use of `==` where appropriate to simplify logic
  ...

# Conflicts:
#	Source/Charts/Data/Implementations/Standard/LineChartDataSet.swift
#	Source/Charts/Renderers/BarChartRenderer.swift
@wuxudong wuxudong mentioned this pull request Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants